Skip to content

Compare several methods for cylinder2D problem#683

Merged
cekees merged 60 commits intomasterfrom
test/cylinder2D
Feb 17, 2018
Merged

Compare several methods for cylinder2D problem#683
cekees merged 60 commits intomasterfrom
test/cylinder2D

Conversation

@wacyyang
Copy link
Contributor

@wacyyang wacyyang commented Jan 10, 2018

In this PR, we are going to collect and compare several methods to solve NSE for the benchmark problem Test 2D-2. The first step is to use exact same setting, compute drag/lift force and compare results with other literature. Those methods include:

  • conforming mesh with rans2p method
  • conforming mesh with rans3p method
  • immerse boundary method
  • shift boundary method

@wacyyang wacyyang self-assigned this Jan 10, 2018
@wacyyang wacyyang requested a review from cekees January 10, 2018 18:30
@codecov
Copy link

codecov bot commented Jan 10, 2018

Codecov Report

Merging #683 into master will increase coverage by 3.23%.
The diff coverage is 83.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   37.64%   40.87%   +3.23%     
==========================================
  Files         207      264      +57     
  Lines       73703    77424    +3721     
==========================================
+ Hits        27745    31647    +3902     
+ Misses      45958    45777     -181
Impacted Files Coverage Δ
proteus/mprans/MCorr3P.py 0% <ø> (ø) ⬆️
proteus/mprans/RANS3PF.py 77.83% <ø> (+77.83%) ⬆️
proteus/mprans/RANS2P.py 77.78% <ø> (+2.81%) ⬆️
...s/tests/cylinder2D/conforming_rans3p/save_batch.py 0% <0%> (ø)
proteus/tests/ProjScheme_with_EV/NS_convergence.py 0% <0%> (ø)
proteus/mprans/VOF3P.py 0% <0%> (ø) ⬆️
proteus/tests/cylinder2D/ibm_method/cylinder_so.py 69.04% <100%> (ø)
...ylinder2D/conforming_rans3p/pressureincrement_p.py 100% <100%> (ø)
.../cylinder2D/conforming_rans3p/pressureInitial_p.py 100% <100%> (ø)
proteus/mprans/PresInc.py 77.32% <100%> (+77.32%) ⬆️
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4add7...8f722ae. Read the comment docs.

1:getDBC_u,
2:getDBC_v}

def getAFBC_p(x,flag):
Copy link
Contributor Author

@wacyyang wacyyang Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cekees I am not sure about this line and line36. Are they correct?

@cekees
Copy link
Member

cekees commented Feb 7, 2018

@wacyyang, could you look over these changes and make sure we don't need to keep any of them before we delete this branch? I went ahead and closed the PR.

@cekees cekees closed this Feb 7, 2018
@cekees cekees reopened this Feb 8, 2018
@wacyyang
Copy link
Contributor Author

wacyyang commented Feb 8, 2018

@cekees I just removed some debug lines, tested rans2p and rans3p methods again and got right drag/lift coefficients. So I think it is safe to merge it into master branch now.

@cekees
Copy link
Member

cekees commented Feb 15, 2018

Couple of ideas:

  • What about putting one main README file in the cylinder2D directory that describes the problem and just short ones explaining the variations in the subdirectories?
  • I'll push up the bit of extra code to add so that these will run on travis (see the changes to setup.py for conforming_rans3p test). You'll need to do the analagous thing for the other test directories.
  • Remove the TODO's from the README and make them github issues or put them in a python docstring in the code with the sphinx .. todo: directive http://www.sphinx-doc.org/en/stable/ext/todo.html
  • Spell and grammar check your README files.

@cekees
Copy link
Member

cekees commented Feb 15, 2018

The tests aren't running for me locally. You should see them run when you do make test in the proteus directory. @manuel-quezada has some experience with these kinds of issues.

@cekees
Copy link
Member

cekees commented Feb 16, 2018

Looks like a path issue in setup.py for the new data files.
https://travis-ci.org/erdc/proteus/builds/342120672#L3954

@cekees cekees merged commit 1d6756f into master Feb 17, 2018
@cekees cekees deleted the test/cylinder2D branch February 17, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants