Compare several methods for cylinder2D problem#683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
+ Coverage 37.64% 40.87% +3.23%
==========================================
Files 207 264 +57
Lines 73703 77424 +3721
==========================================
+ Hits 27745 31647 +3902
+ Misses 45958 45777 -181
Continue to review full report at Codecov.
|
| 1:getDBC_u, | ||
| 2:getDBC_v} | ||
|
|
||
| def getAFBC_p(x,flag): |
There was a problem hiding this comment.
@cekees I am not sure about this line and line36. Are they correct?
|
@wacyyang, could you look over these changes and make sure we don't need to keep any of them before we delete this branch? I went ahead and closed the PR. |
|
@cekees I just removed some debug lines, tested rans2p and rans3p methods again and got right drag/lift coefficients. So I think it is safe to merge it into master branch now. |
|
Couple of ideas:
|
|
The tests aren't running for me locally. You should see them run when you do |
|
Looks like a path issue in |
In this PR, we are going to collect and compare several methods to solve NSE for the benchmark problem Test 2D-2. The first step is to use exact same setting, compute drag/lift force and compare results with other literature. Those methods include: