fix(sidebar): hide stack-member services from flat list#48
Merged
erdembas merged 2 commits intoerdembas:mainfrom Apr 25, 2026
Merged
fix(sidebar): hide stack-member services from flat list#48erdembas merged 2 commits intoerdembas:mainfrom
erdembas merged 2 commits intoerdembas:mainfrom
Conversation
- Added GitStatusChip component to display the current Git status for each service. - Implemented IPC methods for Git operations including fetching branches, checking out branches, creating branches, and stashing changes. - Enhanced the app store to manage Git status snapshots per service. - Created a new git module in the core crate to handle Git operations using the CLI. - Updated LogPanel to show Git status and allow branch management directly from the UI. - Added tests for Git functionalities including status checks, branch creation, and switching.
erdembas
pushed a commit
that referenced
this pull request
Apr 25, 2026
…0.6.0 Adds two entries from #49 (thanks @bedirhansay) into the unreleased 0.6.0 section: - Quality of Life: keyboard-driven UI zoom (Cmd/Ctrl + 0 / - / Shift+0), layout-aware key bindings, localStorage persistence. - Bug Fixes: ScanCache TTL is now instance-scoped so the test suite stops panicking on fresh Windows CI runners with `Instant::now()` < TTL. Sidebar dedup attribution stays as-is (already credited via #48). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Services assigned to a stack were appearing twice in the sidebar —
once inside the stack's detail view and again as standalone entries
under Unassigned / their section. This PR hides stack members from
the flat list so they only surface through the stack row, giving a
clean nested hierarchy.
Changes
SidebarRail.tsx: compute a set of service IDs belonging to anystack and skip them in
filteredServices.hiddenCountso the "Showing N · Mhidden" banner stays filter-only and doesn't misreport nesting as
hiding.
Verification
pnpm typecheckpnpm lintpnpm format:checkcargo fmt --check(src-tauri) — untouched by this PRcargo clippy -- -D warnings(src-tauri) — untouched by thisPR
stack row shows in the sidebar; expanding stack detail still lists
all members; removing a service from the stack brings it back to
the flat list automatically.
Screenshots / demo
Before — stack members duplicated under Unassigned:
After — only non-stack services in the flat list:
Notes for reviewers
One file, ~26 added / 2 removed. Stack detail view,
drag-to-reassign, filter banner, and collapsed sidebar mode are
unchanged. The collapsed (narrow) sidebar icon grid still shows
every service because stacks aren't navigable in that mode —
intentional trade-off.