Update CI matrix & Devise version constraint#24
Merged
erdostom merged 5 commits intoerdostom:masterfrom Nov 25, 2025
Merged
Conversation
Rails < 7.2 doesn't get security fixes anymore. And we don't have to test with Ruby and Mongoid versions that work only with Rails < 7.2 if we don't support Rails < 7.2.
Closed
Owner
|
Thank you Moritz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @erdostom, I updated the version matrix for the CI pipeline and allowed Devise 5 in the gemspec:
[*] Actually, I don't think that 4.0 is the most precise lower bound for the Devise version. Devise requires Rails < 6.0 until version 4.6.2 - so I think we could change the version constraint for Devise to ">= 4.7.0". But it probably doesn't matter since older versions can't be used anyway.