Layout fix #7
Open
Layout fix #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- crmap: show CR as interactive svg map - display map region and unit information and commands on click - orderfile: render orders with wiki links and comments (with markdown) - readnr/shownr: parse NR and detect sections, regions, units - display sections, regions units
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive layout fixes for a tutorial website including automatic pagination for overview pages, improved author and date display with localization, next/previous navigation for reports, and compatibility for online, path-prefixed, and local file system usage.
- Switch overview pages from base-layout to new overview-layout template with automatic pagination
- Add localized author and date display with proper formatting and navigation between reports
- Integrate CRS (map/report rendering) system with CSS/JS auto-inclusion and extensive shortcode support
Reviewed Changes
Copilot reviewed 15 out of 254 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| goblins/index.njk | Changes layout to overview-layout and removes manual post iteration |
| goblins/goblins.json | Adds author field for content attribution |
| css/site.css | Updates comment formatting and adds navigation list styling |
| crs/crs.js | Complete CRS system implementation with map rendering and report parsing |
| crs/crs.css | Comprehensive styling for CR maps, order files, and report displays |
| crs/crs-passthrough.js | Client-side JavaScript for interactive map functionality |
| aquarians/index.njk | Updates layout to overview-layout template |
| aquarians/aquarians.json | Adds author field for aquarian content |
| _includes/post-layout.njk | Enhanced with author display, localized dates, and next/prev navigation |
| _includes/overview-layout.njk | New template for overview pages with automatic post iteration |
| _includes/base-layout.njk | Adds dynamic CSS/JS inclusion, pagination, and relative URL handling |
| _data/site.json | Establishes default locale configuration |
| README.md | Complete rewrite with tutorial authoring instructions |
| .eleventyignore | Adds template directory exclusion |
| .eleventy.js | Major configuration update with CRS integration and relative link handling |
Comment on lines
+9
to
+12
| {% if content.indexOf('crs-requires-css') !== -1 %} | ||
| <link rel="stylesheet" href="{{ '/css/crs.css' }}"> | ||
| {% endif %} | ||
| {% if content.indexOf('crs-requires-js') !== -1 %} |
There was a problem hiding this comment.
Using indexOf to check for CSS/JS requirements in content is fragile and could lead to false positives if the string appears in other contexts. Consider using a more robust method like checking for specific HTML attributes or using a dedicated flag in the front matter.
Suggested change
| {% if content.indexOf('crs-requires-css') !== -1 %} | |
| <link rel="stylesheet" href="{{ '/css/crs.css' }}"> | |
| {% endif %} | |
| {% if content.indexOf('crs-requires-js') !== -1 %} | |
| {% if crs_requires_css %} | |
| <link rel="stylesheet" href="{{ '/css/crs.css' }}"> | |
| {% endif %} | |
| {% if crs_requires_js %} |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Einige Layoutverbesserungen: