edf: RegisterTypeOf now strictly enforces field visibility checks #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
misleading PR description
EDF has never supported it. It always falls on the decoding of the unexported field. |
Author
Apologies, I'm not very familiar with ergo. I've revised the description and commit messages accordingly. |
Collaborator
|
Please fix the title to reflect what this change does. |
chopdown
changed the title
Tochemey
reviewed
Mar 9, 2025
| f := tov.Field(i) | ||
| ft := f.Type | ||
|
|
||
| if f.IsExported() == false { |
There was a problem hiding this comment.
Suggested change
| if f.IsExported() == false { | |
| if !f.IsExported(){ |
This is nit
Collaborator
There was a problem hiding this comment.
I personally prefer to use more readable way of such expressions.
Collaborator
|
It's been fixed in v310 branch already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
EDF RegisterTypeOf now strictly enforces field visibility checks.
Related: #209 #210