Fixed remaining issues for IAW fitting#85
Merged
Merged
Conversation
…tions initialized using the Mora Yahi formulation
parameterized by LTx and LTy now
fixed EDF axes storage surfaced all parameters of bg algorithm fixed case sensitivity for bg type move calculation of used points to postprocessing switched plotting and parameter logging back to fitted parameters only
updated to new colormap
reenable sequential fitting
Updated loss calculations to postporocess with chi squared Fixed plot scaling issue Updated env files to prevent package issues
Updated calibrations for 106310 Added casefold to background naming on ions
Re-enabled holding Ti same and fract summing to 1
fixed single species fraction bug Fixed bug reporting final losses
…, and the inverse activation function is needed to initialize parameters correctly
joglekara
requested changes
Mar 24, 2025
Member
joglekara
left a comment
joglekara
left a comment
There was a problem hiding this comment.
Looks fine. Some things require removal and tidying up
added 2 commits
March 26, 2025 10:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated a number of the tests with some that still need updates as they were created with the parameter initialization bug