Implement signing of P2PKH address type #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this update it was only possible to create transactions for P2SH and P2WPKH addresses.
Now it is also possible to create and sign transactions for P2PKH addresses.
Address Types Examples:
P2PKH: 8KWs4zfdiZt5ywdfxiZBNVqpN33Q6uADnE
P2SH: dYYDGkxDwZryP1K8Ks9NNQKGVQrWjpivF5
P2WPKH: df1q9zn73ca4mt39qe76mkxa4vf4caqsxuhk8d9wgw