Conversation
added 5 commits
April 2, 2019 15:24
…eft in callbacks.js
ghost
approved these changes
Apr 4, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Nice job on this, Eric.
What looks good: Well thought out code. Consider: what other approaches could be used to solve the individual challenges? Commits are good.
What can improve:
- Limit white space for readability.
- You have a nice start to practicing commits and comments; increasing frequency will help you find a given piece of code should you ever have to revert.
- Push yourself by attemtping to complete stretch goals (if you have time during the week) or revisit them at a later time perhaps on a weekend. This isn't a requirement, but just a challenge to help you hone your skills as a developer.
Grade: 2
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.