End-to-end verification, OpenAPI fixes, and CI improvements#2
Merged
Conversation
Alpine-based Node images don't trust the corporate proxy root cert, causing npm ci to fail. Inject the cert into Alpine's CA bundle and set NODE_EXTRA_CA_CERTS in both build and dev stages. Also add docker/certs to the Tiltfile only filter for the web-ui build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Swashbuckle 7.2.0 didn't support .NET 10, so Swagger UI returned nothing. Upgrade to 10.1.5 (and Microsoft.AspNetCore.OpenApi to 10.0.4), simplify AddSwaggerGen calls to avoid removed OpenApiInfo type, and remove the dev-only gate so OpenAPI docs are always served. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename the Swagger UI route prefix and JSON endpoint template from /swagger to /openapi to avoid the defunct Swagger branding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Document the Node/Alpine corporate proxy cert workaround (manual CA bundle approach), split cert instructions by base image type, and add OpenAPI conventions for Swashbuckle v10 route configuration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sync the demo script with all changes made during end-to-end testing: - Solution structure: fix skills list, k8s filenames, add docker/certs, Dockerfile.web, shared packages - CLAUDE.md section: add Docker/Tilt, Nginx, Vite, and OpenAPI conventions - Replace non-existent hooks config with actual enabledPlugins settings - Fix /swagger references to /openapi throughout prompts and demo narration - Update NuGet package versions appendix to match Directory.Packages.props - Add corporate proxy cert handling to Dockerfile instructions - Add MidstreamHub.Nominations.Messages shared package Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace ProcessTasks.StartProcess with DockerTasks.DockerBuild so that Nuke's [LogErrorAsStandard] attribute handles Docker's stderr output correctly. Also skip services whose source directories don't exist yet. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/swaggerto/openapiDockerTasksinstead ofProcessTasksto resolve stderr logging, skip services without source directoriesTest plan
nukebuild passes (0 warnings, 40 tests)nuke DockerBuildsucceeds locally/openapifor both APIs🤖 Generated with Claude Code