ci(security): add govulncheck (blocking) and gosec (informational) scanners#514
Merged
Conversation
…ev target Three independent developer-tooling designs from a brainstorming session: - pre-commit hook (gofmt + go vet + golangci-lint --fast-only, blocking) - CI security scanners (govulncheck blocking + standalone gosec informational) - k3s dev deployment target (CLUSTER=k3s, self-contained remote cluster) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kk9GxWS9EpazjbwBKfMpUX
…s, k3s dev target One plan per spec: - pre-commit hook (2 tasks) - CI security scanners (4 tasks) - k3s dev target (6 tasks + pre-flight); flags migration-Job -> startup-AutoMigrate deviation Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kk9GxWS9EpazjbwBKfMpUX
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two security-scanner jobs to
.github/workflows/security.yml, alongside the existing CodeQL workflow and thegosecalready embedded ingolangci-lint:govulncheck(blocking) —govulncheck ./..., pinned@v1.1.4. Fails the build on any called known vulnerability. Pre-flight confirmed the module is currently clean, so enabling this as a gate is safe today.gosec(informational) —gosec -no-fail -exclude-generated -exclude-dir=.tmi-clients -fmt sarif ..., pinned@v2.22.5. Never blocks the build; uploads SARIF to the Security → Code scanning tab (category: gosec).Both reuse the existing checkout +
setup-go+ tmi-clients replace-shim pattern. CodeQL and the linter-embeddedgosecare intentionally left as-is (broader scope + Security-tab visibility is the point).Design & plan
docs/superpowers/specs/2026-07-01-ci-security-scanners-design.mddocs/superpowers/plans/2026-07-01-ci-security-scanners.mdReview note
Whole-branch review caught one real issue, now fixed: the "informational"
gosecSARIF upload would turn red on Dependabot/fork PRs (read-onlyGITHUB_TOKENcan't satisfysecurity-events: write, soupload-sarif403s). Resolved by marking the upload stepcontinue-on-error: true— it still posts to the Security tab on normal branch/main runs but never blocks.Follow-ups (post-merge)
Vulnerability Scan (govulncheck)a required status check inmainbranch protection so it blocks merges. (Do NOT addgosec— informational by design.)security.yml(current repo convention is major-tag pinning).govulncheck/gosecto Dependabot so their pinned versions auto-bump.🤖 Generated with Claude Code