CE: Add hamburger menu to landing page mobile nav#279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add mobile hamburger menu to the standalone landing page nav to fix overflow on narrow viewports.
Why
Landing page nav links overflow and overlap on mobile (390px). All other pages use page_shell which already has a hamburger menu (added in PRs #274/#278). The landing page uses a standalone nav that missed this treatment.
Changes
.nav-hamburgerbutton (3-line icon) to nav, hidden on desktoparia-labelfor accessibilityTest