Skip to content

Conversation

@xsuchy09
Copy link
Contributor

@xsuchy09 xsuchy09 commented Jul 18, 2022

First of all thanks for your great job!

I added some parameters to some queries. Changes are described in git log:

  • add - new traits / parameters for queries (boost, case_insensitive, format, minimum_should_match, rewrite)
  • edit - queries - new parameters
  • edit - tests including new parameters
  • fix - PrefixQuery has no boost (according to documentation)
  • fix - QueryStringTest renamed to QueryStringQueryTest, RankFeatureTest renamed to RankFeatureQueryTest
  • add - missing tests
  • edit - phpstan - highest level is 9 now
  • edit - .gitignore - .editorconfig added (but I can recommend to add it to the repository - but with yours settings)

xsuchy09 added 4 commits July 18, 2022 16:40
…format, minimum_should_match, rewrite)

*edit - queries - new parameters
*edit - tests including new parameters
*fix - PrefixQuery has no boost (according to documentation)
*fix - QueryStringTest renamed to QueryStringQueryTest, RankFeatureTest renamed to RankFeatureQueryTest
*add - missing tests
*edit - phpstan - highest level is 9 now
*edit - .gitignore - .editorconfig added (but I can recommend to add it to the repository - but with yours settings)
@xsuchy09
Copy link
Contributor Author

@erichard ?

@erichard erichard merged commit ac875a5 into erichard:main Aug 24, 2022
@erichard
Copy link
Owner

Sorry the delay 🙏

@xsuchy09 xsuchy09 deleted the feature/parameters branch December 13, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants