Conversation
There was a problem hiding this comment.
Pull request overview
Adds optional HMAC-based signatures to outgoing webhook requests and updates configuration/docs to support per-endpoint signing keys.
Changes:
- Introduce
webhook.SignandX-Certmatic-Signatureheader generation (timestamp + HMAC-SHA256). - Extend webhook dispatcher configuration from
URLs []stringtoEndpoints []Endpointwith optionalsigning_key. - Update Caddyfile parsing, in-memory dispatcher delivery, tests, and documentation to reflect signed webhooks.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents new url { signing_key ... } syntax and links to signature docs. |
| pkg/webhook/signature.go | Implements signature header construction for webhook deliveries. |
| pkg/webhook/signature_test.go | Adds unit tests for signature formatting and HMAC correctness. |
| pkg/webhook/dispatcher.go | Introduces Endpoint struct and updates dispatcher config schema. |
| internal/webhook/memory.go | Signs requests per-endpoint when SigningKey is configured. |
| internal/webhook/memory_test.go | Updates existing tests for endpoints and adds signature/no-signature tests. |
| internal/caddy/config.go | Parses nested signing_key blocks under each webhook url. |
| internal/caddy/app.go | Wires Endpoints into the dispatcher provisioning path. |
| docs/webhook-signature.md | Adds standalone documentation for webhook signature verification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
120654b to
b608929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.