Fix help#45
Merged
ericvaandering merged 2 commits into8_8_9_brfrom Apr 17, 2018
Merged
Conversation
ericvaandering
force-pushed
the
fix_help
branch
from
03330eb to
eae91a1
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems there must have been an underlying library change that broke this at some point. Fixed by moving to the Simple XML parser, but as a side effect all the HTML encoding from the help text had to be removed. Most of this was pretty extraneous. If we want, we can consider adding it back in with a something like [tag] being translated to