Skip to content

Pass Metronome props to Track; calculated recording length#38

Merged
ericyd merged 5 commits intomainfrom
refactoring
Dec 14, 2022
Merged

Pass Metronome props to Track; calculated recording length#38
ericyd merged 5 commits intomainfrom
refactoring

Conversation

@ericyd
Copy link
Copy Markdown
Owner

@ericyd ericyd commented Dec 14, 2022

Major

  • move Scene and Track under Metronome, and pass key Metronome props to Scene + Track
  • revert to a calculated "recording length", based on metronome props, instead of using the reported recording length from the recorder worklet

Minor

  • update console calls to logger (except in the export worker which doesn't have access to the window global)
  • refactor "useDecayingSine" to the hooks directory, and rename hook

@ericyd ericyd merged commit c06e81a into main Dec 14, 2022
@ericyd ericyd deleted the refactoring branch December 14, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant