Conversation
Owner
ericyd
commented
Dec 14, 2022
- use half of the recording latency as the buffer offset. Not sure why half the reported latency sounds good but it seems to!
- instead of just dropping the part of the audio that would normally be trimmed due to latency, stick it on the end of the buffer. In theory, if the first part of the buffer contained a transient, this might allow the transient to hit at the very end of the loop and "connect" back to the beginning. 🤷🏻 It's a little bit of a shot in the dark, but it didn't seem to harm anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.