mapReduce: final txn must be executed in reduecer because require "all receipts of block" #15205
Merged
AskAlexSharov merged 3 commits intomainfrom May 22, 2025
Merged
mapReduce: final txn must be executed in reduecer because require "all receipts of block" #15205AskAlexSharov merged 3 commits intomainfrom
reduecer because require "all receipts of block" #15205AskAlexSharov merged 3 commits intomainfrom
Conversation
Collaborator
AskAlexSharov
commented
May 22, 2025
AskAlexSharov
commented
- also added access list to warmup
AskAlexSharov
force-pushed
the
deadlock_31
branch
from
23b2b49 to
fde0d04
Compare
This was referenced May 22, 2025
| workersExited := &atomic.Bool{} | ||
| go func() { | ||
| workers.Wait() | ||
| if err := workers.Wait(); err != nil { |
Member
There was a problem hiding this comment.
we do a workers.Wait() later on and log error; we should do it here too.
Collaborator
Author
There was a problem hiding this comment.
It’s in gotoutine. Something like “if workers dead - then need stop main loop”.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.