Skip to content

Call downloader.Delete() for state files#16609

Merged
AskAlexSharov merged 29 commits intorelease/3.1from
alex/cal_del_31
Aug 14, 2025
Merged

Call downloader.Delete() for state files#16609
AskAlexSharov merged 29 commits intorelease/3.1from
alex/cal_del_31

Conversation

@AskAlexSharov
Copy link
Copy Markdown
Collaborator

@AskAlexSharov AskAlexSharov commented Aug 13, 2025

todo left:

  • I changed onChange hook: from names list to relative paths list (need to check if this is what downloader expecting)
  • To check if downloader.Del called and removed from lib

Not in todo:

  • correct notifications about new files (it's less distractive)

Will continue work on it tomorrow

@AskAlexSharov AskAlexSharov changed the title [wip] call downloader.Delete() for state files Call downloader.Delete() for state files Aug 14, 2025
Copy link
Copy Markdown
Member

@sudeepdino008 sudeepdino008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
so as far as i understand:

  • onFilesChange(nil) in a bunch of places can be populated later; it only delays new files getting seeded, which is fine.
  • but onFilesDelete is more important as in, we must pass right value so they're removed from downloader and aren't resurrected.

@AskAlexSharov AskAlexSharov merged commit 9c68546 into release/3.1 Aug 14, 2025
9 checks passed
@AskAlexSharov AskAlexSharov deleted the alex/cal_del_31 branch August 14, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants