Call downloader.Delete() for state files#16609
Merged
AskAlexSharov merged 29 commits intorelease/3.1from Aug 14, 2025
Merged
Conversation
9dfdc39 to
6848973
Compare
sudeepdino008
approved these changes
Aug 14, 2025
Member
sudeepdino008
left a comment
There was a problem hiding this comment.
Looks good!
so as far as i understand:
onFilesChange(nil)in a bunch of places can be populated later; it only delays new files getting seeded, which is fine.- but
onFilesDeleteis more important as in, we must pass right value so they're removed from downloader and aren't resurrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo left:
onChangehook: from names list to relative paths list (need to check if this is what downloader expecting)Not in todo:
Will continue work on it tomorrow