Normalize naming prevStep -> step#17726
Merged
Merged
Conversation
…higher level functions
wmitsuda
requested review from
AskAlexSharov and
sudeepdino008
as code owners
AskAlexSharov
approved these changes
Oct 31, 2025
mh0lt
pushed a commit
that referenced
this pull request
Nov 4, 2025
Small rename refactoring to clarify meaning in the code: - The concept of "prev step" is only used in SharedDomains as GetLatest() is used as prev value of next mutation - Inside GetLatest() chain of calls it is actually just the step whose that latest mutation occurred, "prev step" sounds strange and confusing when reading the code - Most of GetLatest() chain of calls are already using only "step" as the named variable, so this PR just completes the standardization of naming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small rename refactoring to clarify meaning in the code: