Conversation
2e4ecba to
f0b1866
Compare
79259cc to
9b8ca1c
Compare
sudeepdino008
approved these changes
Feb 7, 2026
Member
sudeepdino008
left a comment
There was a problem hiding this comment.
the only place i can think of adding it is in erigon-snapshot repo, in the mirror workflow (which copies the gh merged toml to the webseeds)
Contributor
Author
|
I will try to get it merged in. There's some low-hanging fruit with reusing etags and not refetching stuff to make it check webseeds extremely quickly. It outputs JSON to allow quick queries on the state of things and cause of failure. |
ad06b69 to
ab894f4
Compare
Sahil-4555
pushed a commit
to Sahil-4555/erigon
that referenced
this pull request
Feb 11, 2026
I added a subcommand to check webseed snapshot data matches the
preverified/chain.tomls after we had an issue with a torrent file not
matching its data file on hoodi.
I'm not sure where the command should go, or what it should be called. I
put it as `snapshots preverified` for now in `cmd/erigon`, but it
doesn't quite fit in with the flags and assumed handling that occurs. So
maybe it belongs in `cmd/downloader`.
It reuses the `--preverified` flag from `snapshots reset`, which is very
useful.
I also exported the signal listener for use with subcommands, not just
the default command, so you can cancel them and get proper cleanup.
Update:
I've added it as cmd/downloader verify_webseeds as well.
I've used it to test gnosis webseed issues:
```
GOFLAGS='-race -v' just run-raw-erigon-cmd downloader --chain gnosis webseed_verify --preverified embedded | tee -i out
jq < out '.gnosis | map_values(select(.Err)) | to_entries | map({name: .key, err: .value.Err}) | .[]' -c > gnosis
```
wmitsuda
added a commit
that referenced
this pull request
Feb 15, 2026
PR #18755 accidentally passed `base` (the webseed URL) for both the `webseedUrlBase` and `name` parameters of GetMetainfoFromWebseed, producing URLs like: https://host/https://host/.torrent Pass the snapshot `name` instead so webseedMetainfoUrl correctly builds: webseedUrlBase + name + ".torrent". Fixes #19094 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
wmitsuda
added a commit
that referenced
this pull request
Feb 15, 2026
PR #18755 accidentally passed `base` (the webseed URL) for both the `webseedUrlBase` and `name` parameters of GetMetainfoFromWebseed, producing URLs like: https://host/https://host/.torrent Pass the snapshot `name` instead so webseedMetainfoUrl correctly builds: webseedUrlBase + name + ".torrent". Fixes #19094 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wmitsuda
added a commit
that referenced
this pull request
Feb 16, 2026
## Summary - PR #18755 ("Add webseed checker") accidentally passed `base` for both `webseedUrlBase` and `name` in `GetMetainfoFromWebseed`, producing doubled URLs like `https://host/https://host/.torrent` which return HTTP 404 - Fix: pass the snapshot `name` instead of `base` as the second argument Fixes #19094 ## Test plan - [x] Built and ran an ephemeral mainnet instance for 2 minutes — no `"error fetching metainfo from webseeds"` warnings, all 305/305 file metadata fetched, webseed download steady at ~62-70 MB/s 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a subcommand to check webseed snapshot data matches the preverified/chain.tomls after we had an issue with a torrent file not matching its data file on hoodi.
I'm not sure where the command should go, or what it should be called. I put it as
snapshots preverifiedfor now incmd/erigon, but it doesn't quite fit in with the flags and assumed handling that occurs. So maybe it belongs incmd/downloader.It reuses the
--preverifiedflag fromsnapshots reset, which is very useful.I also exported the signal listener for use with subcommands, not just the default command, so you can cancel them and get proper cleanup.
Update:
I've added it as cmd/downloader verify_webseeds as well.
I've used it to test gnosis webseed issues: