execution: fix Chiado re-exec from genesis#18846
Merged
AskAlexSharov merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
AskAlexSharov
approved these changes
Jan 29, 2026
Member
|
Legend! |
yperbasis
added a commit
that referenced
this pull request
Jan 30, 2026
Cherry pick #18846 to `release/3.3`
Giulio2002
added a commit
that referenced
this pull request
Feb 2, 2026
Add early return for zero-value transfers to avoid unnecessary state operations. This restores performance that was regressed by PR #18846 which removed the zero-check from SubBalance() for Gnosis compatibility. The fix is safe because: - Account creation/touching is handled by CreateAccount() before Transfer() - EIP-7708 log emission is already guarded by !amount.IsZero() Benchmark improvement: - call-identity: 176ms -> 128ms (27% faster) - call-EOA: 194ms -> 144ms (26% faster) - Allocations reduced from 1.3M+ to near zero Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Giulio2002
added a commit
that referenced
this pull request
Feb 2, 2026
…hains Add early return for zero-value transfers to avoid unnecessary state operations. The check is skipped for Aura chains (Gnosis) which need zero-value transfers to touch accounts for state root compatibility. This restores performance that was regressed by PR #18846 which removed the zero-check from SubBalance() for Gnosis compatibility. Benchmark improvement (non-Aura chains): - call-identity: 176ms -> 128ms (27% faster) - call-EOA: 194ms -> 144ms (26% faster) - Allocations reduced from 1.3M+ to near zero Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert a change introduced by PR #15387 that was causing Issue #18276. Gnosis has some hacks for an empty
SystemAddress(see #18276 (comment) & PR #5645).TODO: add a test. (I created a test for Erigon 2 in PR #18844, but I haven't ported it to Erigon 3 yet.)