move "batch size estimation" biz-logic from SD to Exec#19011
Merged
AskAlexSharov merged 8 commits intomainfrom Feb 9, 2026
Merged
move "batch size estimation" biz-logic from SD to Exec#19011AskAlexSharov merged 8 commits intomainfrom
AskAlexSharov merged 8 commits intomainfrom
Conversation
AskAlexSharov
requested review from
mh0lt,
sudeepdino008 and
yperbasis
as code owners
sudeepdino008
approved these changes
Feb 6, 2026
Sahil-4555
pushed a commit
to Sahil-4555/erigon
that referenced
this pull request
Feb 11, 2026
) reason: - it creating chicken-egg problem. Can't print in logs size before commitment, then print after commitment - and understand how much data produced commitment. Because "print after" will show over-estimated size. - SD is now having less and less biz-logic. So, `EstimateSize` it's clearly abstraction-leak Before this change i see: ``` buf=512M before commitment buf=9G after commitment ``` but it's not because Commitment producing so much data it's because we "double-estimate": using estimation logic which "predicting RAM usage after Commitment - before commitment", use same prediction "after Commitment" is incorrect - because "we just know how much RAM we using now".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reason:
EstimateSizeit's clearly abstraction-leakBefore this change i see:
but it's not because Commitment producing so much data
it's because we "double-estimate": using estimation logic which "predicting RAM usage after Commitment - before commitment", use same prediction "after Commitment" is incorrect - because "we just know how much RAM we using now".