Fix build warnings on some platforms#19170
Merged
AskAlexSharov merged 1 commit intomainfrom Feb 15, 2026
Merged
Conversation
anacrolix
force-pushed
the
anacrolix/build-warnings-windows
branch
from
96ed3d2 to
596bd61
Compare
AskAlexSharov
approved these changes
Feb 15, 2026
Contributor
Author
|
Can confirm, the other warnings goes away when the strlen does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes warning in log at #19074 (comment)
Fixes #17214 (GCC most likely).
I'm expecting the strlen warning to be fixed, and if the top-level warning thing for cc1 still exists, I'll add a fix for that in this PR.
Need to read the build log for a Windows workflow to confirm.