stage_exec: allow more workers for build/collate/merge#19207
Merged
AskAlexSharov merged 3 commits intomainfrom Feb 19, 2026
Merged
stage_exec: allow more workers for build/collate/merge#19207AskAlexSharov merged 3 commits intomainfrom
AskAlexSharov merged 3 commits intomainfrom
Conversation
bd5de76 to
ccc37bd
Compare
ccc37bd to
fcc73ae
Compare
Collaborator
|
sorry, don't understand this PR |
AskAlexSharov
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm basicaly interested in making stage_exec/stage_custom_Trace/rebuild commitment faster by delaying/reducing the merge operation. Because now we do periodic merges there, and because we produce lot of files and end up "repeating" a lot of the merge.
in offline commands:
one thing was using optimal merge ranges - #19146
instead of periodic build+merge, we can do periodic BuildFilesInBackground(doMerge=false) and then 1 MergeLoop at the end after all executing is done-- I'll do it in some future PR. This ensures one-shot merge of (lots of) step1 files into a big file, rather than progressive merging into bigger and bigger files - which is repeated work.
integration stage_exec currently uses 1 worker for build/merge; it can be more (e.g. spawn_custom_trace use more workers) -- #19207 is meant to increase the number of workers for stage_exec (other offline commands look okay).
I don't intend to change behavior when erigon binary is running - chaintip or no chaintip. Just changing behaviour for offline commands with these changes.