db/state: fix spurious accessor rebuild for post-merge subset files#19987
Merged
AskAlexSharov merged 4 commits intorelease/3.4from Mar 22, 2026
Merged
db/state: fix spurious accessor rebuild for post-merge subset files#19987AskAlexSharov merged 4 commits intorelease/3.4from
AskAlexSharov merged 4 commits intorelease/3.4from
Conversation
Giulio2002
approved these changes
Mar 19, 2026
Collaborator
Giulio2002
left a comment
Giulio2002
left a comment
There was a problem hiding this comment.
LGTM — focused bug fix: Close() methods now properly call closeFilesAndRemove() when refcount drops to 0 with canDelete=true, preventing leaked FDs and spurious accessor rebuilds. Good test coverage.
erigon-copilot Bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
…19987) Co-authored-by: Matt Joiner <anacrolix@gmail.com> Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
…erge subset files (#20077) **[SharovBot]** Cherry-pick of #19987 (from `release/3.4`) to `main`. Fixes spurious accessor rebuild triggered for post-merge subset files in db/state. Co-authored-by: Giulio rebuffo <giulio.rebuffo@gmail.com> Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com> Co-authored-by: Matt Joiner <anacrolix@gmail.com> Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.