Merged
Conversation
Log rpc.max.concurrency, db.read.concurrency, effective limit and GOMAXPROCS to help diagnose admission control behaviour in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Follow the same pattern as qa-rpc-integration-tests-remote.yml: build integration binary alongside rpcdaemon and run migrations on the reference datadir before starting rpcdaemon. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The rpcdaemon stdout is redirected to build/bin/erigon.log but the upload step was looking at ERIGON_REFERENCE_DATA_DIR/logs/rpcdaemon.log. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Speed up test sequence during investigation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Port 8546 is already in use by the paused production erigon instance, causing rpcdaemon to shut down immediately after start. Performance tests use HTTP only so WebSocket is not needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Production erigon holds ports 8545/8546 even when paused. Launch the test rpcdaemon on port 51515 and use --testing-client other-daemon so rpc_perf connects to the correct instance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mriccobene
requested changes
Apr 1, 2026
Member
mriccobene
left a comment
mriccobene
left a comment
There was a problem hiding this comment.
We need to discuss the introduction of the migration procedure.
| working-directory: ${{ github.workspace }}/build/bin | ||
| run: | | ||
| echo "Running migrations on datadir..." | ||
| ./integration run_migrations --datadir $ERIGON_REFERENCE_DATA_DIR --chain $CHAIN |
Member
There was a problem hiding this comment.
We cannot run migrations here; this workflow doesn't save the pre-built db before execution so it is not safe to modify it.
Contributor
Author
There was a problem hiding this comment.
Ok Removed Run Migration step as Ethereum, gnosis WorkFlow
lupin012
added
performance
github_actions
lupin012
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mriccobene
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the new Go implementation within the performance workflow, providing several advantages over the legacy Python scripts:
Note on Migration:
Initially, both Python and Go implementations will be available, but only the Go version will receive future updates. The Python implementation will be deprecated and removed in future PRs.
The updates to the script are: