[wip] main ci is red#20430
Closed
AskAlexSharov wants to merge 3 commits intomainfrom
Closed
Conversation
The optimization to start the DB iterator at max(startTxNum, files.EndTxNum()) assumed files always cover all history entries below EndTxNum. In practice, files may be incomplete (during segment merges, partial rebuilds, etc.), causing the DB iterator to skip real history entries. When history misses a key, DomainRoTx.RangeAsOf falls back to the latest state, incorrectly returning current values for historical queries (e.g., accounts appearing at block 1M that were created later). This caused flaky failures in debug_accountRange and debug_storageRangeAt RPC integration tests on mainnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RangeAsOfDB iterator optimization from db/state: RangeAsOf DB iterator starts from files.EndTxNum() #20360 that started the DB iterator atmax(startTxNum, files.EndTxNum())instead ofstartTxNumEndTxNum(), but files may be incomplete during segment merges or partial rebuildsDomainRoTx.RangeAsOffalls back to the latest state, incorrectly returning current values for historical queries (e.g. accounts created after block 1M appearing indebug_accountRangeat block 1M)Fixes flaky
debug_accountRange/test_05,debug_accountRange/test_25, anddebug_storageRangeAt/test_01failures in mainnet RPC integration tests.