log: less allocs#20455
Merged
AskAlexSharov merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces per-log-record allocations in the common/log/v3 terminal formatter by removing repeated string uppercasing and by caching an environment flag outside the hot formatting path.
Changes:
- Add
Lvl.UpperString()to avoidstrings.ToUpper(r.Lvl.String())on every formatted record. - Cache
ERIGON_LOG_NO_TIMESTAMPSonce perTerminalFormat()instance instead of re-reading it per record. - Add a regression test asserting
TerminalFormatNoColor()’s level prefix and message padding/layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/log/v3/logger.go | Adds Lvl.UpperString() for allocation-free uppercase level strings. |
| common/log/v3/format.go | Uses UpperString() and caches logNoTimestamps outside the formatter closure. |
| common/log/v3/log_test.go | Adds TerminalFormatNoColor() output/layout test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
awskii
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToUpper()call on each formatlogEnvBoolcall on each format