rpc: expose testing_ namespace via --http.api on port 8545#20482
Merged
rpc: expose testing_ namespace via --http.api on port 8545#20482
Conversation
Replace the boolean --rpc.testing flag (engine-port-only, JWT-required) with the standard --http.api mechanism: adding "testing" to the list (e.g. --http.api eth,erigon,testing) registers testing_buildBlockV1 on the plain HTTP port (8545) without JWT, matching Geth's behaviour. The namespace is disabled by default to prevent accidental production exposure. In standalone rpcdaemon mode the entry is silently skipped with a Warn log, since block assembly requires direct execution service access unavailable over gRPC. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lupin012
requested review from
AskAlexSharov,
Giulio2002,
mh0lt and
yperbasis
as code owners
yperbasis
requested changes
Apr 12, 2026
Member
yperbasis
left a comment
yperbasis
left a comment
There was a problem hiding this comment.
Let's make it consistent with geth and don't register the testing_ namespace on the Engine API port.
…port Per reviewer request (yperbasis): align with Geth behaviour by keeping testing_ RPC only on the plain HTTP port. The Engine API (JWT-auth) port must not expose this namespace. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yperbasis
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the boolean --rpc.testing flag (engine-port-only, JWT-required) with the standard --http.api mechanism: adding "testing" to the list (e.g. --http.api eth,erigon,testing) registers testing_buildBlockV1 on the plain HTTP port (8545) without JWT, matching Geth's behaviour.
The namespace is disabled by default to prevent accidental production exposure. In standalone rpcdaemon mode the entry is silently skipped with a Warn log, since block assembly requires direct execution service access unavailable over gRPC.