stagedsync: generate changesets near tip even during initialCycle#20495
Merged
stagedsync: generate changesets near tip even during initialCycle#20495
Conversation
Instead of flipping initialCycle mid-batch in each executor, let shouldGenerateChangeSets handle it directly: generate changesets for blocks within MaxReorgDepth of the batch end regardless of initialCycle. This removes the initialCycle parameter from shouldGenerateChangeSets and the mid-batch initialCycle flips from exec3_serial and exec3_parallel. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yperbasis
requested review from
AskAlexSharov,
Giulio2002,
sudeepdino008 and
taratorio
AskAlexSharov
approved these changes
Apr 11, 2026
AskAlexSharov
pushed a commit
that referenced
this pull request
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldGenerateChangeSetsno longer short-circuits oninitialCycle— changesets are generated for blocks withinMaxReorgDepthof the batch end regardless, so the node can always handle reorgs at the tipinitialCycleparameter fromshouldGenerateChangeSetsCherry-picked from #20445.