clean up PR 20265: remove misleading #20169 attribution from StateCache tests#20498
Merged
clean up PR 20265: remove misleading #20169 attribution from StateCache tests#20498
Conversation
The StateCache fix (PR #20265) is a valid cache correctness improvement, but it wasn't the root cause of Issue #20169 — the real fix was in the domain/snapshot layer (PR #20483). A cache miss falling through to the membatch/MDBX path should return the correct value. - Remove TestStateCacheDeletedStorageSSTOREGas (duplicates TestStateCache_PutEmpty_ThenGet_IsCacheHit, with wrong attribution) - Simplify TestStateCache_PutEmpty_ThenGet_IsCacheHit comment to frame it as a cache correctness property, not a regression test for #20169 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yperbasis
changed the title
yperbasis
requested review from
AskAlexSharov,
Giulio2002,
awskii and
sudeepdino008
AskAlexSharov
approved these changes
Apr 12, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestStateCacheDeletedStorageSSTOREGas— it duplicatedTestStateCache_PutEmpty_ThenGet_IsCacheHitand incorrectly attributed the SSTORE gas mismatch (Gas mismatches on mainnet & Hoodi #20169) to the StateCache layerTestStateCache_PutEmpty_ThenGet_IsCacheHitto frame it as a cache correctness property, not a regression test for Gas mismatches on mainnet & Hoodi #20169The StateCache fix (PR #20265) is a valid cache correctness improvement, but the root cause of #20169 was in the domain/snapshot layer — a cache miss falling through to the membatch/MDBX path should return the correct value. The real fix was PR #20483.