execution: fix BAL recording when coinbase == transaction target#20501
Merged
execution: fix BAL recording when coinbase == transaction target#20501
Conversation
finalizeTx deleted the entire coinbase address from result.TxIn to force a balance re-read from the version map. Because TxIn is a shared map reference (also stored in blockIO), this also destroyed storage/code/nonce reads recorded during EVM execution. When the coinbase was also the transaction target, those execution reads were needed by AsBlockAccessList to produce the correct BAL hash. Replace the blanket delete with ReadSet.Delete targeting only the BalancePath key, which is the only entry that needs re-reading. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yperbasis
changed the title
mh0lt
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coinbase == transaction targetcaused storage/code/nonce reads to be dropped from the BALfinalizeTxuseddelete(result.TxIn, result.Coinbase)which removed the entire address from the shared read-set map, destroying execution reads needed byAsBlockAccessListresult.TxIn.Delete(addr, AccountKey{Path: BalancePath})to surgically remove only the stale balance read, preserving all other readsTest plan
stBugs/random_statetest_default_minus_tue_07_58_41_minus_15153_minus_575192inTestExecutionSpecBlockchainDevnetmake lintcleanmake erigon integrationbuildsTestExecutionSpecBlockchainDevnetsuite on Linux CI🤖 Generated with Claude Code