Revert "logger: avoid mutex contention"#20654
Merged
Merged
Conversation
This reverts commit 02e843b.
![erigon-copilot[bot]](https://avatars.githubusercontent.com/in/3015145?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM. Same reasoning as the release/3.4 revert: the no-mutex logging change is too risky given the blocked-write stacks through streamHandler -> os.File.Write and fdMutex serialization. Restoring SyncHandler for StreamHandler and reintroducing rotatingWriter locking is the safer production choice on main until there is a non-blocking design that preserves correctness under slow stderr/file sinks.
AskAlexSharov
added a commit
to EthGiveawa375/erigon
that referenced
this pull request
Apr 22, 2026
) Reverts erigontech#20654 Because I did miss-interpreted stacktrace as deadlock/race inside logger erigontech#20661 - but it had another Root-Cause
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20454
reason: gnosis stuck #20661