rpc: fix three testing_buildBlockV1 hive test failures#20698
Merged
Conversation
- engine_types/jsonrpc.go: add omitempty to SlotNumber JSON tag so nil slot number is omitted from ExecutionPayloadV3 responses (Prague chain does not include slotNumber, only Amsterdam/V4+) - testing_api.go: return real blockValue from assembler instead of hardcoding zero; nonce validation errors now use -32000 (execution error) instead of -32602 (invalid params) to match execution-apis spec - testing_api_test.go: update assertions accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lupin012
changed the title
canepat
approved these changes
Apr 20, 2026
canepat
deleted the
lupin012/fix_testing_according_PR_783_execution_apis
branch
AskAlexSharov
pushed a commit
that referenced
this pull request
Apr 24, 2026
This PR fixes 3 testing_ api after merge(today) of PR 783 execution_apis: - engine_types/jsonrpc.go: add omitempty to SlotNumber JSON tag so nil slot number is omitted from ExecutionPayloadV3 responses (Prague chain does not include slotNumber, only Amsterdam/V4+) - testing_api.go: return real blockValue from assembler instead of hardcoding zero; - nonce validation errors now use -32000 (execution error) instead of -32602 (invalid params) to match execution-apis spec Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
AskAlexSharov
pushed a commit
that referenced
this pull request
Apr 24, 2026
This PR fixes 3 testing_ api after merge(today) of PR 783 execution_apis: - engine_types/jsonrpc.go: add omitempty to SlotNumber JSON tag so nil slot number is omitted from ExecutionPayloadV3 responses (Prague chain does not include slotNumber, only Amsterdam/V4+) - testing_api.go: return real blockValue from assembler instead of hardcoding zero; - nonce validation errors now use -32000 (execution error) instead of -32602 (invalid params) to match execution-apis spec Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 testing_ api after merge(today) of PR 783 execution_apis: