anacrolix/torrent: Serve peerconn panic fix#20748
Merged
AskAlexSharov merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
anacrolix
force-pushed
the
anacrolix/serve-peerconn-panic
branch
from
43a11b8 to
c7c82f9
Compare
Contributor
Author
|
QA workflows appear stuck, so I'm running manually from scratch on mainnet. |
AskAlexSharov
approved these changes
Apr 23, 2026
Contributor
Author
|
Workflow failures seem to be unrelated. My local test passed. I'll move on to backporting. |
AskAlexSharov
pushed a commit
that referenced
this pull request
Apr 24, 2026
Cherry-pick of #20748 to release/3.4. Closes erigontech/erigon-qa#403 — a rare path where a bad read while serving a peer request broke an invariant and triggered a logic panic. The fix keeps invariants intact on bad reads. Pulled in via bumps: - `github.com/anacrolix/torrent` to the version containing the fix - transitive `github.com/RoaringBitmap/roaring/v2` to v2.16.0 (required by the new torrent version); drops unused indirect `github.com/RoaringBitmap/roaring` v1 Make sure to trigger the first two workflows per the linked issue to verify.
lupin012
pushed a commit
that referenced
this pull request
Apr 24, 2026
Addresses erigontech/erigon-qa#403 in main. Needs to also be backported to 3.4. Looks like a rare path where if there's an issue reading torrent data in order to serve a peer request, then an invariant was broken and triggered a logic panic. The fix ensures that on a bad read the invariants are maintained. Make sure to trigger the first 2 workflows per the issue to verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/erigontech/erigon-qa/issues/403 in main. Needs to also be backported to 3.4.
Looks like a rare path where if there's an issue reading torrent data in order to serve a peer request, then an invariant was broken and triggered a logic panic. The fix ensures that on a bad read the invariants are maintained.
Make sure to trigger the first 2 workflows per the issue to verify.