rpc align debug trace flags with execution-apis spec (#762)#20755
Merged
AskAlexSharov merged 10 commits intomainfrom Apr 26, 2026
Merged
rpc align debug trace flags with execution-apis spec (#762)#20755AskAlexSharov merged 10 commits intomainfrom
AskAlexSharov merged 10 commits intomainfrom
Conversation
lupin012
force-pushed
the
lupin012/trace-enable-flags
branch
from
c728a3d to
1787e4d
Compare
Replace disableMemory/disableReturnData (opt-out, default ON) with enableMemory/enableReturnData (opt-in, default OFF) to match the ethereum/execution-apis#762 spec and Geth behavior. Also adds returnData emission to JsonStreamLogger which was previously missing. evm tool flags (--nomemory/--noreturndata) preserve existing behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… > 63 bytes hexWithPrefix uses a fixed [128]byte buffer which silently truncates return data longer than 63 bytes. Switch to hex.EncodeToString which allocates the correct length. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ncoding Replaces "0x" + hex.EncodeToString with hexutil.Encode which preallocates the exact buffer size in a single allocation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lupin012
force-pushed
the
lupin012/trace-enable-flags
branch
from
87aace3 to
4f46c0c
Compare
…urnData Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…EnableReturnData is set Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lupin012
requested review from
AskAlexSharov,
Giulio2002,
mh0lt,
mriccobene and
yperbasis
as code owners
AskAlexSharov
approved these changes
Apr 25, 2026
Sahil-4555
pushed a commit
to Sahil-4555/erigon
that referenced
this pull request
Apr 27, 2026
…erigontech#20755) Replace disableMemory/disableReturnData (opt-out, default ON) with enableMemory/enableReturnData (opt-in, default OFF) to match the ethereum/execution-apis#762 spec and Geth behavior. Also adds returnData emission to JsonStreamLogger which was previously missing. evm tool flags (--nomemory/--noreturndata) preserve existing behavior. needs Rpc-test tag --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace disableMemory/disableReturnData (opt-out, default ON) with enableMemory/enableReturnData (opt-in, default OFF) to match the ethereum/execution-apis#762 spec and Geth behavior. Also adds returnData emission to JsonStreamLogger which was previously missing. evm tool flags (--nomemory/--noreturndata) preserve existing behavior.
needs Rpc-test tag