ci: temporarily skip debug_traceBlockByNumber/test_{33,34} after prestateTracer fix#20845
Merged
AskAlexSharov merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
… rpc tests #20775 (cherry-picked to main via #20830) fixed prestateTracer diff mode to include deleted accounts in the post state. The two mainnet fixtures test_33 and test_34 still expect the pre-fix output and are now red on every PR — including main itself. The proper fix is in flight at erigontech/rpc-tests#554, which refreshes the expected JSON for both blocks. Once that PR merges and a new tag (v2.8.2+) is cut, this workaround can be reverted and run_rpc_tests_ethereum.sh bumped to the new tag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
@mholte Yes, PR #20830 back-ported the changes from 3.4 to main without updating the rpc-tests. As a result, the tests started failing. I had created a PR on main (PR #20807) to address this while waiting for the new rpc-test tag (merge rpc-test PR #554), but Alex was faster. I’ll fix my branch/PR shortly. The changes on rpc-test and erigon sw as conseguence a fix on Geth on 16 April |
AskAlexSharov
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#20775 (cherry-picked into main via #20830) fixed `prestateTracer` diff mode to include deleted accounts in the `post` state — they were silently missing before, which was the actual bug. Two mainnet rpc-tests fixtures hit blocks where this matters:
Their expected JSON in rpc-tests `v2.8.1` doesn't include those entries, so `mainnet-rpc-integ-tests` is red on every PR — including `main` itself since the cherry-pick landed.
What
Two-line addition to the `DISABLED_TEST_LIST` in `run_rpc_tests_ethereum.sh`. No production-code change.
Follow-up
Proper fix in flight: erigontech/rpc-tests#554 refreshes the expected JSON for both blocks. Once that merges and a new tag (`v2.8.2`+) is cut, this workaround should be reverted and the version bumped in `run_rpc_tests_ethereum.sh` (and the matching cache keys in the qa workflows).
Test plan