db/state: reset reader on recsplit collision retry in SimpleAccessorBuilder#20886
Merged
AskAlexSharov merged 5 commits intoerigontech:mainfrom Apr 30, 2026
Merged
Conversation
…uilder Adds `iidq.reader.Reset(0)` at the top of the retry loop in `SimpleAccessorBuilder.Build`, matching `buildVI` (5c7fe1b) and `buildHashMapAccessor`. Without it, retry iterations start with an exhausted `PagedReader` and feed zero keys to recsplit, producing a corrupt accessor index for forkable snapshots (headers/bodies).
benderrobert
requested review from
AskAlexSharov and
sudeepdino008
as code owners
AskAlexSharov
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
iidq.reader.Reset(0)at the top of the retry loop inSimpleAccessorBuilder.Build, matchingbuildVI(5c7fe1b) andbuildHashMapAccessor. Without it, retry iterations start with an exhaustedPagedReaderand feed zero keys to recsplit, producing a corrupt accessor index for forkable snapshots (headers/bodies).