Added fix to allow getroothash to work with no api running#8342
Merged
Conversation
yperbasis
pushed a commit
that referenced
this pull request
Oct 3, 2023
Whitelisting calculation of the roothash should not be dependent on the bor api running. This will not always be the case, for example when erigon is configured with a separate rpc deamon. To fix this the calculation has been moved to Bor. Additionally the redundant Bor API code has been removed as this is not called by any code and the functionality looks to have migrated to the turbo/jsonrpc package.
Merged
yperbasis
added a commit
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whitelisting calculation of the roothash should not be dependent on the bor api running. This will not always be the case, for example when erigon is configured with a separate rpc deamon.
To fix this the calculation has been moved to Bor.
Additionally the redundant Bor API code has been removed as this is not called by any code and the functionality looks to have migrated to the turbo/jsonrpc package.