txpool: limit transactions outgoing messages (#8271)#8742
Merged
AskAlexSharov merged 2 commits intodevelfrom Nov 20, 2023
Merged
txpool: limit transactions outgoing messages (#8271)#8742AskAlexSharov merged 2 commits intodevelfrom
AskAlexSharov merged 2 commits intodevelfrom
Conversation
Closed
battlmonstr
force-pushed
the
pr/8271
branch
4 times, most recently
from
53d21ab to
8227e7a
Compare
battlmonstr
changed the title
battlmonstr
changed the title
battlmonstr
force-pushed
the
pr/8271
branch
3 times, most recently
from
f10d2ee to
ff90106
Compare
battlmonstr
changed the title
AskAlexSharov
approved these changes
Nov 20, 2023
Broadcasting to 100 peers generates too much outgoing traffic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broadcasting to 100 peers generates too much outgoing traffic.
Before it was sending 5.5-6.5 MiB/sec:
With the fixes it stays at 3-3.5 MiB/sec:
P.S. A baseline if everything is disabled (BroadcastPooledTxs, AnnouncePooledTxs, responses to GetPooledTransactions) is 0.5-1 MiB/sec.