Merged
Conversation
Giulio2002
requested changes
Nov 30, 2023
Collaborator
Giulio2002
left a comment
Giulio2002
left a comment
There was a problem hiding this comment.
Overall LGTM, just few adjustments needed
Contributor
|
I would replace ratelimiter with this |
Collaborator
Agree, that would get rid of most of the responsibility on us to mantain. |
Giulio2002
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add the request rate limiter.
The solution is to count the request number for each peer for each minute, if the peer exceeds the limit, block the requests for a specified time.
Current limits:
5000requests per minute for each handler.1-minute