Merged
Conversation
AskAlexSharov
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first "smoke test", part of the QA practices to help devs and the support team to identify as soon as possible, code regressions that are not detected by the actual Erigon CI/CD test suite or are not easily detectable with a standard Github Action workflow because they need a long running execution of Erigon.
This QA test runs on a self-hosted github action runner that is hosted on our bare metal machine.
It launches Erigon in detached mode and simultaneously a python script implementing the test logic. In this case, the script after a certain amount of time sends a signal corresponding to ctrl-c and looks in the logs to verify that Erigon has exited cleanly.
The python script is part of our private erigon-qa repository and it is available on our machine.
Despite this, the QA tests will be seamlessly integrated into our github space and will be visible next to the other tests performed in the usual way.
Quality assurance has a wide scope, it is a big topic. We will start with a first, more focused goal: building a smoke test suite. Next, in the long run, we will build the service that takes the execution metrics.