Merged
Conversation
battlmonstr
force-pushed
the
pr/sw_seg_fuzz
branch
from
3ac36f5 to
8b501a9
Compare
A test that generates an input file, compresses it using both erigon and silkworm, and compares that the result matches.
battlmonstr
force-pushed
the
pr/sw_seg_fuzz
branch
from
8b501a9 to
3b69209
Compare
AskAlexSharov
approved these changes
Feb 16, 2024
| investigationDir, _ := os.LookupEnv("INVESTIGATION_DIR") | ||
|
|
||
| f.Add(int64(0)) | ||
| f.Fuzz(func(t *testing.T, seed int64) { |
Collaborator
There was a problem hiding this comment.
i think it's a bit anti-pattern: to use input of fuzz test as random seed. because fuzzing framework trying to mutate input to increase code coverage - but "any meaningful seed mutation" will change code coverage randomly(or likely will not change at all - because 1 random data-set will look very similar to another random data-set).
Better give more control for fuzzer: more input params, more tide input params to data-set.
Contributor
Author
There was a problem hiding this comment.
yes, I've used Fuzz, because the other files here have used it. I should probably rewrite it from Fuzz to quick.Check, because Fuzz doesn't support custom generators, and generation here is complicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test that generates an input file,
compresses it using both erigon and silkworm,
and compares that the result matches.