Add 13 new plan analysis rules to PlanAnalyzer#327
Merged
erikdarlingdata merged 2 commits intodevfrom Feb 26, 2026
Merged
Conversation
Expands the plan analyzer from 11 to 24 rules with domain-specific detection patterns for common SQL Server performance anti-patterns. New rules: - Non-SARGable predicates (CONVERT_IMPLICIT, function calls, ISNULL, leading wildcard LIKE, CASE expressions) - Data type mismatch (GetRangeWithMismatchedTypes) - Lazy spool ineffective rebind/rewind ratio - Join OR clause expansion (Concatenation + Constant Scan) - Nested Loops high inner-side execution count - Many-to-many Merge Join - Large memory grant with sort/hash consumer identification - Compile memory exceeded (early abort) - High compile CPU (>= 1000ms) - Local variables without RECOMPILE - CTE referenced multiple times - Table variable detection - Table-valued function detection - Top above rowstore scan Also fixes existing scan rules to exclude columnstore indexes (designed to be scanned) and extracts IsRowstoreScan() helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ction reorder - Add statement-level Rule 4 check for UDF execution timing from QueryTimeStats (some plans report UDF timing only at statement level, not per-node) - Reorder non-SARGable detection: check CASE expression before CONVERT_IMPLICIT since CASE bodies often contain CONVERT_IMPLICIT that isn't the root cause Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsRowstoreScan()helper for consistent rowstore scan detectionTest plan
YEAR()orDATEPART()in WHERE — verify function call detection🤖 Generated with Claude Code