Fix UDF timing units: microseconds to milliseconds#338
Merged
erikdarlingdata merged 1 commit intodevfrom Feb 27, 2026
Merged
Conversation
Plan XML UdfCpuTime/UdfElapsedTime values are milliseconds, not microseconds. The property names, /1000 division in PlanAnalyzer, and "us" labels in the properties panel were all wrong — showing 1/1000th of real time and making the critical severity threshold effectively unreachable. - Rename UdfCpuTimeUs/UdfElapsedTimeUs → UdfCpuTimeMs/UdfElapsedTimeMs - Remove /1000.0 division in Rule 4, use values directly - Fix properties panel labels from "us" to "ms" - Both Dashboard and Lite Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UdfCpuTime/UdfElapsedTimevalues are milliseconds, not microseconds/1000division in PlanAnalyzer Rule 4, and "us" labels in the properties panel were all wrongTest plan
🤖 Generated with Claude Code