Skip to content

Rule 15: Restore join ancestor check alongside Merge Interval#350

Merged
erikdarlingdata merged 1 commit intodevfrom
fix/rule-15-restore-join-ancestor
Feb 27, 2026
Merged

Rule 15: Restore join ancestor check alongside Merge Interval#350
erikdarlingdata merged 1 commit intodevfrom
fix/rule-15-restore-join-ancestor

Conversation

@erikdarlingdata
Copy link
Owner

Summary

  • Rule 15 (Join OR Clause): Restore HasJoinAncestor check that was incorrectly removed in PR Rule 15: Use Merge Interval for OR expansion detection #349
  • Merge Interval is the strongest signal, but the join ancestor check is a broader catch — both should be present
  • Now fires when Concatenation + Constant Scans appears under either a Merge Interval or a join

Test plan

  • dotnet build clean (0 errors) for Dashboard and Lite
  • plan-b 32/32 tests pass

🤖 Generated with Claude Code

Merge Interval + TopN Sort is the strongest signal for OR expansion,
but the join ancestor check is a broader catch that shouldn't have
been removed. Now fires on either condition.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit b85dca5 into dev Feb 27, 2026
3 checks passed
@erikdarlingdata erikdarlingdata deleted the fix/rule-15-restore-join-ancestor branch February 27, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant