Fix UTC/local timezone mismatch in blocked process XML processor#383
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 1, 2026
Merged
Fix UTC/local timezone mismatch in blocked process XML processor#383erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
The processor was passing UTC dates (from XE @timestamp) to sp_HumanEventsBlockViewer which expects local time inputs. This caused double UTC conversion internally, and the verification query compared UTC dates against local-time parsed results — always returning 0 matches. All 86 recent failures were caused by this bug. Adds @utc_offset_minutes conversion so derived UTC dates are translated to local before being passed to sp_HumanEventsBlockViewer, the DELETE of stale parsed results, and the verification COUNT. Raw table UPDATE still uses UTC dates correctly. Matches the pattern already used in 25_process_deadlock_xml.sql. Tested on sql2022: 489 XML events processed, 118 parsed blocking events created, scheduled job confirmed working end-to-end. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@timestamp) tosp_HumanEventsBlockViewer, which expects local time inputsNO_RESULTSfailures inconfig.collection_logwere caused by this bugDATEDIFF(MINUTE, GETUTCDATE(), SYSDATETIME())) matching the pattern already used in25_process_deadlock_xml.sqlTest plan
@debug = 1🤖 Generated with Claude Code