Sync PlanAnalyzer improvements from PerformanceStudio#480
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 9, 2026
Merged
Sync PlanAnalyzer improvements from PerformanceStudio#480erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
- Fix Rule 28: Row Count Spool detection now uses .Contains() to match parser's "Lazy Row Count Spool" PhysicalOp prefix - Rule 11: Strip PROBE() bitmap filter noise from scan predicate display - Rules 11/24: Soften prescriptive wording to "Check that you have appropriate indexes" instead of "Create an index on the predicate columns" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.Contains("Row Count Spool")instead of exact match — parser prepends "Lazy"/"Eager" prefix to spool operators, so the old exact match never firedStripProbeExpressions()helper)Dashboard and Lite remain in sync (namespace-only diff).
Test plan
🤖 Generated with Claude Code