Fix PerfMon first-value spike that skews graphs#483
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 9, 2026
Merged
Conversation
…482) The first collection with no baseline stored the raw cumulative DMV value as the delta, creating a massive spike that skewed the chart Y-axis. Added baselineOnly parameter to DeltaCalculator.CalculateDelta — when true, the first sighting returns 0 (baseline only) instead of the raw cumulative value. Applied to perfmon, wait stats, file I/O, and memory grant collectors. Query/proc stats keep the existing behavior so single-execution queries still surface in top-N views. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Hi @erikdarlingdata. Wow, what a rapid response! 🚀 I noticed the scope was expanded to the following files, which is great: However, I've picked up that _deltaCalculator.CalculateDelta is also used in:
These are currently not included in the commit and (for graphing) it does affect:
As the scope was expanded by this commit, I figured it would makes sense to include it on this branch? Kind regards, |
Owner
Author
|
Totally fine here. I can pick it up. Thanks for letting me know, as always. |
3 tasks
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
baselineOnlyparameter toDeltaCalculator.CalculateDelta()— whentrue, the first read stores the baseline and returns0instead of the raw cumulative valueTest plan
🤖 Generated with Claude Code