Add Query Store collector spike diagnostic timing#518
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 11, 2026
Merged
Conversation
Splits the DuckDB write stopwatch into three components (SqlDataReader, appender, flush) and logs a warning when total exceeds 2 seconds. This identified SQL Server Query Store DMV contention as the root cause of collector spikes during heavy analytical workloads — not DuckDB writes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Mar 11, 2026
Add missing changelog entries for PRs #503-#518: DuckDB 1.5.0 upgrade, parquet compaction (13-26x perf improvement), SignPath code signing, ReadOnlyIntent, status bar used/file size, collector diagnostics, plan viewer fixes. Update README with code signing note, DuckDB 1.5.0 data storage section, ReadOnlyIntent quick start, expanded FinOps description. Release date set to 2026-03-11. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
During HammerDB TPC-H load testing, the Query Store collector showed 7-22 second spikes. This diagnostic identified the root cause: SQL Server's Query Store DMVs are slow to return rows under heavy analytical workload (reader: 11,764ms, append: 20ms, flush: 10ms). DuckDB is not the bottleneck.
Test plan
🤖 Generated with Claude Code